-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/rate limiter #5295
Release/rate limiter #5295
Conversation
src/app/pages/swap/components/swap-asset-select/swap-asset-select-base.tsx
Show resolved
Hide resolved
Code LGTM. I took it for a spin testing it with a few wallets including Ledger (STX only, BTC only + both) I was able to perform a swap, initiate send ordinal etc. All looks good but when testing a wallet with a lot of accounts it was taking a long time to load balances sometimes. They do load eventually. Maybe thats improved in #5296? I also noticed these console errors which I'm not sure if they are new or not. When increasing STX fee I had a 429 and the spinner kept showing: |
cc/ @fbwoolf on market data error. Do we expect this to happen? If so, maybe a different technique to handle is needed besides logger.error |
Let me look at this, it can likely be removed and is just a Stacks ft alex isn't handling. The logger.error seems unec, but I want to make sure I'm right here. I'll put up a quick PR this morn to remove it so it can get added here. |
PR here to include: #5309 |
Contains:
sendTransfer
should default tomainnet
if nonetwork
provided #5284