Fix inaccurate fee estimations

[kyranjamie]

Try out Leather build aab07ae — Extension build, Test report, Storybook, Chromatic

This PR fixes the issues relating to fee estimations describe in Notion.

The previously calculation lead to a situation whereby some estimations would be counting one fewer input than actually used, thus vastly decreasing the fee rate.

Open to feedback how we can extend the tests of the coin selection.

@fbwoolf can you please QA this to double check

2024-04-25-000182.mp4

[fbwoolf]

cc @314159265359879 to help QA here?

[fbwoolf]

Code looks good here, and I'm not running into any bugs testing it. 👍

[alter-eggo]

@kyranjamie I believe we need to fix calc in selectTaprootInscriptionTransferCoins as well?

[alter-eggo]

checked btc send with 3ns inputs and 2ns outputs and it worked for me 👍

[kyranjamie]

@kyranjamie I believe we need to fix calc in selectTaprootInscriptionTransferCoins as well?

Eurgh, this needs refactoring. Though I think it doesn't have same problem, as the other with the for loop.

[alter-eggo]

as I understand we can skip adding _outputs_counts for different output types? 🤔
like it is now in getSizeInfoMultipleRecipients

[kyranjamie]

Not entirely sure what you mean by this @alter-eggo ?

[kyranjamie]

You do this as well in the multiple recipients code acc[type + '_output_count'] = count;

[kyranjamie]

Open for changes if needed here, but merging to not hold up fixes