Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bitcoin send flow to accept multiple recipients #5321

Merged
merged 1 commit into from
May 3, 2024
Merged

refactor: bitcoin send flow to accept multiple recipients #5321

merged 1 commit into from
May 3, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Apr 26, 2024 •
edited by leather-bot
Loading

Try out Leather build a89dbca — Extension build, Test report, Storybook, Chromatic

This pr refactors bitcoin send flows to accept multiple recipients, like it is in rpc send transfer flow

@alter-eggo alter-eggo changed the title refactor: remove multiple recipients components refactor: bitcoin send flow to accept multiple recipients Apr 26, 2024
@alter-eggo alter-eggo force-pushed the refactor/multiple-recipients branch from ba99041 to 6bdfc7f Compare May 1, 2024 12:40
@alter-eggo alter-eggo marked this pull request as ready for review May 1, 2024 12:40
@alter-eggo alter-eggo force-pushed the refactor/multiple-recipients branch from 6bdfc7f to be74268 Compare May 1, 2024 12:48
@alter-eggo alter-eggo requested a review from kyranjamie May 1, 2024 12:49
@markmhendrickson
Copy link
Collaborator

What are the "Bitcoin send flows" in particular – are these separate API(s) from "send transfer flows"?

@alter-eggo
Copy link
Contributor Author

@markmhendrickson

  • btc send flow
  • brc-20 send flow
  • inscription send flow
  • rpc send transfer flow

to support multiple recipients feature, I had to duplicate a lot of code. in this pr I removed it

kyranjamie
kyranjamie approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @alter-eggo, love to see this
image

src/app/common/transactions/bitcoin/coinselect/local-coin-selection.ts Outdated Show resolved Hide resolved
src/shared/models/form.model.ts Outdated Show resolved Hide resolved
@alter-eggo alter-eggo force-pushed the refactor/multiple-recipients branch from be74268 to f06a3c0 Compare May 2, 2024 11:34
@alter-eggo alter-eggo force-pushed the refactor/multiple-recipients branch from f06a3c0 to a89dbca Compare May 2, 2024 14:41
@alter-eggo alter-eggo added this pull request to the merge queue May 3, 2024
Merged via the queue into dev with commit 8f83bcc May 3, 2024
28 checks passed
@alter-eggo alter-eggo deleted the refactor/multiple-recipients branch May 3, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alter-eggo @markmhendrickson @kyranjamie