fix: show correct amount for nonWitnessUtxo, ref #5113

[pete-watters]

Try out Leather build 2abad35 — Extension build, Test report, Storybook, Chromatic

This PR ensures we display the amount correctly when trying to sign nonWitnessUtxos with ledger.

Summary by CodeRabbit

• New Features

  • Improved Bitcoin transaction signing process for enhanced reliability and accuracy.

• Bug Fixes

  • Added conditional checks to prevent unnecessary updates to transaction data, ensuring data integrity.

[coderabbitai]

Walkthrough

The recent updates enhance Bitcoin transaction handling in two key areas. First, new utility functions getBitcoinInputValue and isDefined are integrated to streamline input value retrieval and conditional checks. Second, a safeguard ensures nonWitnessUtxo is not redundantly updated in transactions. These changes aim to improve code clarity and transaction accuracy.

Changes

Files	Change Summary
src/app/features/ledger/flows/bitcoin-tx-signing/steps/approve-bitcoin-sign-ledger-tx.tsx	Added getBitcoinInputValue and isDefined functions to imports. Replaced direct input access with getBitcoinInputValue.
src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts	Added conditional check for nonWitnessUtxo update. Imported isDefined and analytics.

In code we trust, with changes bright,
Bitcoin flows with guided light.
Inputs checked, values clear,
Transactions now, have no fear.
🎉🔐✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5d9895f and d239e56.

Files selected for processing (2)

• src/app/features/ledger/flows/bitcoin-tx-signing/steps/approve-bitcoin-sign-ledger-tx.tsx (2 hunks)
• src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts (2 hunks)

Files skipped from review due to trivial changes (1)

• src/app/features/ledger/flows/bitcoin-tx-signing/steps/approve-bitcoin-sign-ledger-tx.tsx

Additional comments not posted (1)

src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts (1)

18-18: The addition of isDefined and reverseBytes from @shared/utils aligns with the need for robust data manipulation and validation as described in the PR summary. This change supports the new functionality introduced in the transaction update functions.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d239e56 and 76fa95e.

Files selected for processing (2)

• src/app/features/ledger/flows/bitcoin-tx-signing/steps/approve-bitcoin-sign-ledger-tx.tsx (2 hunks)
• src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts (2 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/app/features/ledger/flows/bitcoin-tx-signing/steps/approve-bitcoin-sign-ledger-tx.tsx
• src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 76fa95e and aaf9edf.

Files selected for processing (1)

• src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/app/store/accounts/blockchain/bitcoin/native-segwit-account.hooks.ts

[kyranjamie]

Thanks @pete-watters

[pete-watters]

Thanks @pete-watters

Thank you for your patience with me 🙏

[pete-watters]

@kyranjamie @fbwoolf: I'll merge this now as it's showing the right amount thanks to #5363.

Let me know if you need me to change anything else in a follow up. I can add the multi-sig example to test-app if you think its worth it?

[kyranjamie]

@kyranjamie @fbwoolf: I'll merge this now as it's showing the right amount thanks to #5363.

To the best of my understanding, the changes in #5363 didn't actually change any functionality FYI, just refactored it to be more readable 🤔