feat: enable uninscribed utxos retrieval, closes #5067 #5370

alter-eggo · 2024-05-14T14:44:24Z

Try out Leather build 68795d1 — Extension build, Test report, Storybook, Chromatic

This pr re-enables btc retrieval

Summary by CodeRabbit

New Features
- Enabled recovery of uninscribed Taproot UTXOs.
- Enabled Runes feature.
Improvements
- Improved layout alignment in the Collectibles section for better visual consistency.
- Adjusted spacing in the Retrieve Taproot to Native Segwit section for improved readability.
- Enhanced UTXO filtering by introducing a minimum value threshold, ensuring more relevant data is displayed.

coderabbitai · 2024-05-14T14:44:33Z

Walkthrough

The recent changes bring enhancements to the wallet configuration, Collectibles layout, and Taproot balance logic. These updates enable new features, improve layout alignment, and refine UTXO filtering based on value.

Changes

File Path	Change Summary
`config/wallet-config.json`	Enabled `recoverUninscribedTaprootUtxosFeature` and `runesEnabled` features.
`src/app/features/collectibles/components/collectible.layout.tsx`	Adjusted layout by adding `alignItems="center"` to `Flex` component in `CollectiblesLayout`.
`src/app/query/bitcoin/balance/btc-taproot-balance.hooks.ts`	Introduced `RETRIEVE_UTXO_DUST_AMOUNT` constant and updated UTXO filtering logic.

🐇
In the land of code where bytes do flow,
Features awaken, new functions grow.
Alignments centered, UTXOs refined,
With Runes enabled, treasures you'll find.
A rabbit's delight, in changes so bright,
Coding adventures take flight in the night. ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kyranjamie · 2024-05-14T14:46:56Z

src/app/query/bitcoin/balance/btc-taproot-balance.hooks.ts

@@ -18,7 +20,7 @@ export function useCurrentTaprootAccountUninscribedUtxos() {
    const inscriptions = query.data?.pages?.flatMap(page => page.inscriptions) ?? [];
    return filterUtxosWithInscriptions(
      inscriptions,
-      utxos.filter(utxo => utxo.status.confirmed)
+      utxos.filter(utxo => utxo.status.confirmed && utxo.value > RETRIEVE_UTXO_DUST_AMOUNT)


Personal pref, but more readable as separate filters imo

Suggested change

utxos.filter(utxo => utxo.status.confirmed && utxo.value > RETRIEVE_UTXO_DUST_AMOUNT)

utxos

.filter(utxo => utxo.status.confirmed)

.filter(utxo => utxo.value > RETRIEVE_UTXO_DUST_AMOUNT)

put to sep variable also

and increased dust amount. should be 10000

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 61b8171 and 58b1bd8.

Files selected for processing (4)

config/wallet-config.json (1 hunks)
src/app/features/collectibles/components/collectible.layout.tsx (1 hunks)
src/app/features/retrieve-taproot-to-native-segwit/components/retrieve-taproot-to-native-segwit.layout.tsx (1 hunks)
src/app/query/bitcoin/balance/btc-taproot-balance.hooks.ts (2 hunks)

Additional comments not posted (5)

src/app/query/bitcoin/balance/btc-taproot-balance.hooks.ts (2)

12-12: Addition of RETRIEVE_UTXO_DUST_AMOUNT constant looks good.

23-23: The updated filtering logic in useCurrentTaprootAccountUninscribedUtxos enhances the function by excluding UTXOs with a value less than RETRIEVE_UTXO_DUST_AMOUNT.

src/app/features/collectibles/components/collectible.layout.tsx (1)

26-26: The addition of alignItems="center" in the Flex component improves the visual alignment of items within the CollectiblesLayout.

src/app/features/retrieve-taproot-to-native-segwit/components/retrieve-taproot-to-native-segwit.layout.tsx (1)

54-54: Changing the mt property to my in the styled.span component ensures consistent vertical margins.

config/wallet-config.json (1)

103-103: Enabling recoverUninscribedTaprootUtxosFeature in the configuration aligns with the PR objective of re-enabling BTC retrieval.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 58b1bd8 and 68795d1.

Files selected for processing (4)

config/wallet-config.json (1 hunks)
src/app/features/collectibles/components/collectible.layout.tsx (1 hunks)
src/app/features/retrieve-taproot-to-native-segwit/components/retrieve-taproot-to-native-segwit.layout.tsx (1 hunks)
src/app/query/bitcoin/balance/btc-taproot-balance.hooks.ts (1 hunks)

Files skipped from review as they are similar to previous changes (4)

config/wallet-config.json
src/app/features/collectibles/components/collectible.layout.tsx
src/app/features/retrieve-taproot-to-native-segwit/components/retrieve-taproot-to-native-segwit.layout.tsx
src/app/query/bitcoin/balance/btc-taproot-balance.hooks.ts

markmhendrickson · 2024-05-15T08:31:06Z

Are we skipping this "B" enhancement from the issue for now?

alter-eggo · 2024-05-15T10:49:05Z

@markmhendrickson yes

alter-eggo requested a review from kyranjamie May 14, 2024 14:44

kyranjamie approved these changes May 14, 2024

View reviewed changes

coderabbitai bot reviewed May 14, 2024

View reviewed changes

feat: enable btc retrieval, closes #5067

68795d1

alter-eggo force-pushed the feat/enable-btc-retrieval branch from 58b1bd8 to 68795d1 Compare May 14, 2024 14:55

coderabbitai bot reviewed May 14, 2024

View reviewed changes

alter-eggo added this pull request to the merge queue May 14, 2024

Merged via the queue into dev with commit 92d9603 May 14, 2024
28 checks passed

alter-eggo deleted the feat/enable-btc-retrieval branch May 14, 2024 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable uninscribed utxos retrieval, closes #5067 #5370

feat: enable uninscribed utxos retrieval, closes #5067 #5370

alter-eggo commented May 14, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 14, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

kyranjamie May 14, 2024

alter-eggo May 14, 2024

alter-eggo May 14, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

markmhendrickson commented May 15, 2024

alter-eggo commented May 15, 2024

feat: enable uninscribed utxos retrieval, closes #5067 #5370

feat: enable uninscribed utxos retrieval, closes #5067 #5370

Conversation

alter-eggo commented May 14, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented May 14, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

kyranjamie May 14, 2024

Choose a reason for hiding this comment

alter-eggo May 14, 2024

Choose a reason for hiding this comment

alter-eggo May 14, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

markmhendrickson commented May 15, 2024

alter-eggo commented May 15, 2024

alter-eggo commented May 14, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 14, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)