-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add defensive code and better analytics for broadcast errors, … #5375
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,7 @@ export function useCurrentAccountNativeSegwitAddressIndexZero() { | |
*/ | ||
export function useNativeSegwitAccountIndexAddressIndexZero(accountIndex: number) { | ||
const signer = useNativeSegwitSigner(accountIndex)?.(0); | ||
// could it be this? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding this note as the error thrown was I see the deprecation warning above this function but I don't understand what it means.
Does that mean I can refactor this to use |
||
return signer?.payment.address as string; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added analytics to errors that bring us to the broadcast error screen. I am unsure what we should use analytics for though.