Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stamp error reporting #5389

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented May 20, 2024

Try out Leather build 807f55fExtension build, Test report, Storybook, Chromatic

I think, because it's an instance of an error, it isn't reporting properly, and that spreading the error props, initialising a new obj, fixes it.

Summary by CodeRabbit

  • Refactor

    • Simplified the rendering logic in the Stamps component for better code readability.
  • Bug Fixes

    • Improved error tracking in the fetchStampsByAddress function to include detailed error information.

Copy link

coderabbitai bot commented May 20, 2024

Walkthrough

The recent updates aim to simplify and enhance the codebase for improved readability and functionality. The Stamps component now directly maps over stamps for rendering, while fetchStampsByAddress in the query module has improved error tracking by spreading error objects in the tracking data.

Changes

File Path Change Summary
src/app/features/collectibles/components/bitcoin/stamps.tsx Simplified the Stamps function by directly mapping over stamps to render Stamp components.
src/app/query/bitcoin/stamps/stamps-by-address.query.ts Enhanced error tracking by spreading the error object in fetchStampsByAddress.

🐇
In code we trust, with changes bright,
Simplified paths, errors in sight.
Mapping stamps with ease and grace,
Errors tracked, a smoother pace.
Code refined, our spirits light!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kyranjamie kyranjamie force-pushed the fix/stamp-validation-error-tracking branch from f69bacc to df82faf Compare May 20, 2024 09:26
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a36dae4 and df82faf.
Files selected for processing (2)
  • src/app/features/collectibles/components/bitcoin/stamps.tsx (1 hunks)
  • src/app/query/bitcoin/stamps/stamps-by-address.query.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/app/features/collectibles/components/bitcoin/stamps.tsx
Additional comments not posted (1)
src/app/query/bitcoin/stamps/stamps-by-address.query.ts (1)

83-83: Ensure the spread operator captures all relevant ZodError properties.

@kyranjamie kyranjamie requested a review from fbwoolf May 20, 2024 15:27
@kyranjamie kyranjamie force-pushed the fix/stamp-validation-error-tracking branch from df82faf to 807f55f Compare May 20, 2024 16:34
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between df82faf and 807f55f.
Files selected for processing (2)
  • src/app/features/collectibles/components/bitcoin/stamps.tsx (1 hunks)
  • src/app/query/bitcoin/stamps/stamps-by-address.query.ts (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • src/app/features/collectibles/components/bitcoin/stamps.tsx
  • src/app/query/bitcoin/stamps/stamps-by-address.query.ts

@kyranjamie kyranjamie added this pull request to the merge queue May 21, 2024
Merged via the queue into dev with commit 9b77421 May 21, 2024
28 checks passed
@kyranjamie kyranjamie deleted the fix/stamp-validation-error-tracking branch May 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants