Fix/hover effect for disabled button

[pete-watters]

Try out Leather build c3585a1 — Extension build, Test report, Storybook, Chromatic

Summary by CodeRabbit

• Enhancements
  • Improved the sign-out button's hover effect to dynamically change background color based on the user's ability to sign out.

[coderabbitai]

Walkthrough

The recent update enhances the SignOutDialog component by making the hover background color of a Button dynamically change based on the canSignOut condition. This provides a more responsive and visually intuitive user experience. Additionally, the button's opacity is adjusted to reflect the same condition, ensuring that the button's state is clearly communicated to the user.

Changes

File Path	Change Summary
src/app/features/settings/sign-out/...	Modified _hover property of a Button to change background color based on canSignOut condition. Adjusted opacity for the same condition.

🐇
Buttons now with dynamic flair,
Hovering shows we truly care,
Conditional colors, opacity too,
Enhancing the sign-out view.
— CodeRabbit 🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kyranjamie]

Appreciate the contribution, but let's not merge.

Disabled buttons should never have a hover state, so fixing it in only one place isn't a good solution

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0c6c4d1 and c3585a1.

Files selected for processing (1)

• src/app/features/settings/sign-out/sign-out.tsx (1 hunks)

Additional comments not posted (2)

src/app/features/settings/sign-out/sign-out.tsx (2)

47-47: Ensure the conditional logic for _hover and opacity properties aligns with the intended behavior.

The changes correctly implement the conditional styling based on the canSignOut state, enhancing the user interface by providing visual feedback on the button's functionality.

---

47-47: Good use of a guard clause in the onClick handler.

The conditional execution in the onClick handler (canSignOut && onUserDeleteWallet()) is a good practice, ensuring that the function only executes when the button is active.