-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename org #5564
refactor: rename org #5564
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 243 files out of 297 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThe overall change involves updating URLs from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
src/app/features/container/utils/get-popup-header.ts (3)
Line range hint
14-14
: Duplicate case label in switch statement.The
RouteUrls.RpcStacksSignature
case is duplicated in the switch statement, which could lead to unintended behavior or confusion.- case RouteUrls.RpcStacksSignature:
Line range hint
43-43
: Useless case clause in switch statement.The
RouteUrls.RpcSendTransfer
case is redundant because it is already covered by the default case which returns false.- case RouteUrls.RpcSendTransfer:
Line range hint
70-70
: Duplicate case label in switch statement.The cases
RouteUrls.TransactionRequest
andRouteUrls.SignatureRequest
are duplicated, which could potentially lead to errors or unexpected behavior.- case RouteUrls.TransactionRequest: - case RouteUrls.SignatureRequest:Also applies to: 75-75
README.md (2)
Line range hint
14-14
: Markdown heading levels should increment properly.Please adjust the heading levels to ensure they increment by one level at a time for better readability and compliance with markdown best practices.
- ### Contibuting + ## ContributingTools
LanguageTool
[grammar] ~141-~141: A determiner may be missing. (THE_SUPERLATIVE)
Context: ...rt In Q1 2021, Leather partnered with Least Authority...
Line range hint
90-90
: Specify language for fenced code blocks.To improve readability and syntax highlighting, please specify the language for the fenced code block.
- ```bash + ```bashTools
LanguageTool
[grammar] ~141-~141: A determiner may be missing. (THE_SUPERLATIVE)
Context: ...rt In Q1 2021, Leather partnered with Least Authority...
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .github/workflows/contributor-advice.yml (1 hunks)
- README.md (1 hunks)
- package.json (1 hunks)
- src/app/features/container/utils/get-popup-header.ts (1 hunks)
- src/app/pages/swap/alex-swap-container.tsx (1 hunks)
- src/background/popup.ts (1 hunks)
Files skipped from review due to trivial changes (4)
- .github/workflows/contributor-advice.yml
- package.json
- src/app/pages/swap/alex-swap-container.tsx
- src/background/popup.ts
Additional context used
Biome
src/app/features/container/utils/get-popup-header.ts
[error] 14-14: Duplicate case label. (lint/suspicious/noDuplicateCase)
The first similar label is here:
[error] 43-43: Useless case clause. (lint/complexity/noUselessSwitchCase)
because the default clause is present:
Unsafe fix: Remove the useless case.
[error] 70-70: Duplicate case label. (lint/suspicious/noDuplicateCase)
The first similar label is here:
[error] 75-75: Duplicate case label. (lint/suspicious/noDuplicateCase)
The first similar label is here:
LanguageTool
README.md
[grammar] ~22-~22: Consider using either the past participle “run” or the present participle “running” here. (BEEN_PART_AGREEMENT)
Context: ...sents the script context in which it is ran. ### Install packages ```bash pnpm i ...
[style] ~59-~59: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ... tests expect the extension to be built prior to running. The extension can be built for...
[uncategorized] ~79-~79: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...test:integrationTo run a suite of tests you can use:
bash pnpm playwright t...
[style] ~86-~86: Consider using a more formal alternative. (MORE_INFO)
Context: ...est tests/specs --shard=3/8 ``` To get more information when running tests you can pass the `--...
[uncategorized] ~86-~86: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...To get more information when running tests you can pass the
--debug` flag or the ...
[grammar] ~86-~86: The word ‘playwright’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb. (VB_TO_NN_DT)
Context: ...s the--debug
flag or the--ui
flag to playwright. When running tests locally you must a...
[uncategorized] ~137-~137: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...io](mailto:[email protected]) Please note this email is strictly for reporting se...
[style] ~137-~137: ‘taken into account’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_TAKEN_INTO_ACCOUNT)
Context: ...s are sincerely appreciated and will be taken into account to acknowledge your contributions. ###...
[grammar] ~141-~141: A determiner may be missing. (THE_SUPERLATIVE)
Context: ...rt In Q1 2021, Leather partnered with Least Authority...
Markdownlint
README.md
14-14: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
90-90: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (4)
src/app/features/container/utils/get-popup-header.ts (3)
2-2
: Updated URL in the comment.The comment has been updated to reflect the new organization name in the GitHub URL. This change is consistent with the PR's objective to update URLs across the project.
Line range hint
24-29
: General review of function logic.The function
showBalanceInfo
is structured well and aligns with the expected behavior for showing balance information based on different routes.
Line range hint
24-29
: General review of function logic.The function
isKnownPopupRoute
correctly identifies known popup routes and is implemented without any visible issues.README.md (1)
143-143
: Updated URL in the README.The audit report URL has been updated to reflect the new organization name. This change aligns with the PR's objective to update URLs across the project.
@kyranjamie if I search |
Will update again now that the packages are published |
cfe23ca
to
ef8e579
Compare
f83ea48
to
396ad83
Compare
396ad83
to
c554f4d
Compare
New Github org name
Summary by CodeRabbit
leather-wallet
toleather-io
for consistency and accuracy.