Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename org #5564

Merged
merged 2 commits into from
Jun 24, 2024
Merged

refactor: rename org #5564

merged 2 commits into from
Jun 24, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Jun 21, 2024

New Github org name

Summary by CodeRabbit

  • Chores
    • Updated URLs across the project from leather-wallet to leather-io for consistency and accuracy.
  • Documentation
    • Revised links in the README to point to the correct security audit report.

Copy link

coderabbitai bot commented Jun 21, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

243 files out of 297 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The overall change involves updating URLs from leather-wallet to leather-io across various documentation, configuration, and comments within the codebase. This change ensures all references to the organization are consistent and up-to-date with the new organization name.

Changes

Files Change Summary
.github/workflows/contributor-advice.yml Updated URL in the workflow file related to contributor guidelines.
README.md Updated the link to the security audit report to reflect the new organization name.
package.json Changed the repository URL to the new organization name.
src/app/features/container/utils/get-popup-header.ts Updated a URL in the comments related to the POPUP header logic.
src/app/pages/swap/alex-swap-container.tsx Updated a URL in the comment related to sponsorship by Alex.
src/background/popup.ts Updated a URL in a comment from leather-wallet to leather-io.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kyranjamie kyranjamie requested a review from fbwoolf June 21, 2024 11:42
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (5)
src/app/features/container/utils/get-popup-header.ts (3)

Line range hint 14-14: Duplicate case label in switch statement.

The RouteUrls.RpcStacksSignature case is duplicated in the switch statement, which could lead to unintended behavior or confusion.

-    case RouteUrls.RpcStacksSignature:

Line range hint 43-43: Useless case clause in switch statement.

The RouteUrls.RpcSendTransfer case is redundant because it is already covered by the default case which returns false.

-    case RouteUrls.RpcSendTransfer:

Line range hint 70-70: Duplicate case label in switch statement.

The cases RouteUrls.TransactionRequest and RouteUrls.SignatureRequest are duplicated, which could potentially lead to errors or unexpected behavior.

-    case RouteUrls.TransactionRequest:
-    case RouteUrls.SignatureRequest:

Also applies to: 75-75

README.md (2)

Line range hint 14-14: Markdown heading levels should increment properly.

Please adjust the heading levels to ensure they increment by one level at a time for better readability and compliance with markdown best practices.

- ### Contibuting
+ ## Contributing
Tools
LanguageTool

[grammar] ~141-~141: A determiner may be missing. (THE_SUPERLATIVE)
Context: ...rt In Q1 2021, Leather partnered with Least Authority...


Line range hint 90-90: Specify language for fenced code blocks.

To improve readability and syntax highlighting, please specify the language for the fenced code block.

- ```bash
+ ```bash
Tools
LanguageTool

[grammar] ~141-~141: A determiner may be missing. (THE_SUPERLATIVE)
Context: ...rt In Q1 2021, Leather partnered with Least Authority...

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c61ced0 and cfe23ca.

Files selected for processing (6)
  • .github/workflows/contributor-advice.yml (1 hunks)
  • README.md (1 hunks)
  • package.json (1 hunks)
  • src/app/features/container/utils/get-popup-header.ts (1 hunks)
  • src/app/pages/swap/alex-swap-container.tsx (1 hunks)
  • src/background/popup.ts (1 hunks)
Files skipped from review due to trivial changes (4)
  • .github/workflows/contributor-advice.yml
  • package.json
  • src/app/pages/swap/alex-swap-container.tsx
  • src/background/popup.ts
Additional context used
Biome
src/app/features/container/utils/get-popup-header.ts

[error] 14-14: Duplicate case label. (lint/suspicious/noDuplicateCase)

The first similar label is here:


[error] 43-43: Useless case clause. (lint/complexity/noUselessSwitchCase)

because the default clause is present:

Unsafe fix: Remove the useless case.


[error] 70-70: Duplicate case label. (lint/suspicious/noDuplicateCase)

The first similar label is here:


[error] 75-75: Duplicate case label. (lint/suspicious/noDuplicateCase)

The first similar label is here:

LanguageTool
README.md

[grammar] ~22-~22: Consider using either the past participle “run” or the present participle “running” here. (BEEN_PART_AGREEMENT)
Context: ...sents the script context in which it is ran. ### Install packages ```bash pnpm i ...


[style] ~59-~59: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ... tests expect the extension to be built prior to running. The extension can be built for...


[uncategorized] ~79-~79: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...test:integration To run a suite of tests you can use: bash pnpm playwright t...


[style] ~86-~86: Consider using a more formal alternative. (MORE_INFO)
Context: ...est tests/specs --shard=3/8 ``` To get more information when running tests you can pass the `--...


[uncategorized] ~86-~86: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... To get more information when running tests you can pass the--debug` flag or the ...


[grammar] ~86-~86: The word ‘playwright’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb. (VB_TO_NN_DT)
Context: ...s the --debug flag or the --ui flag to playwright. When running tests locally you must a...


[uncategorized] ~137-~137: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...io](mailto:[email protected]) Please note this email is strictly for reporting se...


[style] ~137-~137: ‘taken into account’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_TAKEN_INTO_ACCOUNT)
Context: ...s are sincerely appreciated and will be taken into account to acknowledge your contributions. ###...


[grammar] ~141-~141: A determiner may be missing. (THE_SUPERLATIVE)
Context: ...rt In Q1 2021, Leather partnered with Least Authority...

Markdownlint
README.md

14-14: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


90-90: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified

Additional comments not posted (4)
src/app/features/container/utils/get-popup-header.ts (3)

2-2: Updated URL in the comment.

The comment has been updated to reflect the new organization name in the GitHub URL. This change is consistent with the PR's objective to update URLs across the project.


Line range hint 24-29: General review of function logic.

The function showBalanceInfo is structured well and aligns with the expected behavior for showing balance information based on different routes.


Line range hint 24-29: General review of function logic.

The function isKnownPopupRoute correctly identifies known popup routes and is implemented without any visible issues.

README.md (1)

143-143: Updated URL in the README.

The audit report URL has been updated to reflect the new organization name. This change aligns with the PR's objective to update URLs across the project.

@fbwoolf
Copy link
Contributor

fbwoolf commented Jun 21, 2024

@kyranjamie if I search leather wallet, there are still uses in the code, not sure if we are wanting to replace those too?

@kyranjamie
Copy link
Collaborator Author

Will update again now that the packages are published

@kyranjamie kyranjamie force-pushed the chore/renamed-org branch 4 times, most recently from f83ea48 to 396ad83 Compare June 21, 2024 15:51
@kyranjamie kyranjamie added this pull request to the merge queue Jun 24, 2024
Merged via the queue into dev with commit 7851c44 Jun 24, 2024
29 checks passed
@kyranjamie kyranjamie deleted the chore/renamed-org branch June 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants