Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Leather to WBIP004 array #5617

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: add Leather to WBIP004 array #5617

merged 1 commit into from
Jul 8, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Jul 5, 2024 •
edited by coderabbitai bot
Loading

Closes #5615

Adds support for https://wbips.netlify.app/wbips/WBIP004

Summary by CodeRabbit

  • New Features

    • Added "Leather" as a new provider to the list of Bitcoin wallet providers, with specific details like icons and URLs.

  • Chores

    • Corrected a typo in a comment related to account restoration functionality.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 5, 2024 •
edited
Loading

Walkthrough

The changes span multiple files and primarily introduce a new Bitcoin wallet provider called "Leather" by adding an interface definition and a function. This update enables compatibility with WBIP Web Providers and enhances the account restoration functionality. Additionally, an import and function call are included in inpage.ts to integrate "Leather."

Changes

Files Change Summary
.../common/account-restoration/legacy-gaia-config-lookup.ts Corrected a typo in a comment related to the account restoration function.
.../inpage/add-leather-to-providers.ts Added WalletProvider interface with new properties and implemented addLeatherToProviders() function.
.../inpage/inpage.ts Imported addLeatherToProviders and added a call to this function before ExtensionResponse declaration.

Assessment against linked issues

Objective (Issue No.) Addressed Explanation
Add Leather to the window.btc_providers array (#5615) ✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 5, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7728eeb and f984822.

Files selected for processing (3)
  • src/app/common/account-restoration/legacy-gaia-config-lookup.ts (1 hunks)
  • src/inpage/add-leather-to-providers.ts (1 hunks)
  • src/inpage/inpage.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/app/common/account-restoration/legacy-gaia-config-lookup.ts
Additional comments not posted (6)
src/inpage/add-leather-to-providers.ts (4)

1-14: Well-defined interface.

The WalletProvider interface is well-structured and includes relevant properties for wallet providers.

17-41: Function implementation looks good.

The addLeatherToProviders function correctly adds the Leather provider to the window.btc_providers array.

2-2: Clear and useful comments.

The inline comments provide helpful context and references.

Also applies to: 3-3, 4-4, 6-6, 8-8, 9-9, 10-10, 11-11, 13-13, 16-16, 20-20

25-25: Appropriate use of data URI for the icon.

The data URI is a suitable method for embedding the icon image directly in the code.

src/inpage/inpage.ts (2)

25-25: Correct import statement.

The addLeatherToProviders function is correctly imported from ./add-leather-to-providers.

29-29: Correct function call placement.

The addLeatherToProviders function is correctly called before the ExtensionResponse interface declaration.

edgarkhanzadian
edgarkhanzadian approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@edgarkhanzadian edgarkhanzadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

pete-watters
pete-watters reviewed Jul 5, 2024
View reviewed changes
src/inpage/add-leather-to-providers.ts Outdated
@@ -0,0 +1,41 @@
interface WalletProvider {
id: string; // Path on global/window object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal but we don’t need all of those explanation comments

@kyranjamie kyranjamie force-pushed the feat/push-providers-array branch from f984822 to 70a3d76 Compare July 8, 2024 08:04
coderabbitai[bot]
coderabbitai bot reviewed Jul 8, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f984822 and 70a3d76.

Files selected for processing (3)
  • src/app/common/account-restoration/legacy-gaia-config-lookup.ts (1 hunks)
  • src/inpage/add-leather-to-providers.ts (1 hunks)
  • src/inpage/inpage.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/app/common/account-restoration/legacy-gaia-config-lookup.ts
Files skipped from review as they are similar to previous changes (2)
  • src/inpage/add-leather-to-providers.ts
  • src/inpage/inpage.ts

@markmhendrickson markmhendrickson added this pull request to the merge queue Jul 8, 2024
Merged via the queue into dev with commit e38f6ab Jul 8, 2024
29 checks passed
@markmhendrickson markmhendrickson deleted the feat/push-providers-array branch July 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@alter-eggo alter-eggo alter-eggo approved these changes

@edgarkhanzadian edgarkhanzadian edgarkhanzadian approved these changes

@pete-watters pete-watters pete-watters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WBIP Web Providers compatibility
5 participants
@kyranjamie @pete-watters @edgarkhanzadian @alter-eggo @markmhendrickson