fix: account change in open frames #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Looks good. Even retains state of the current route 👏 Screen.Recording.2024-08-01.at.15.28.13.mov |
markmhendrickson
approved these changes
Aug 1, 2024
|
@pete-watters let's include in #5726? |
alter-eggo
approved these changes
Aug 5, 2024
kyranjamie
force-pushed
the
update-account-changes
branch
from
dd81f36 to
02f640c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement I figured was quite easy, noticing the wallet not updating in background in one of Mark's earlier videos.
2024-08-01-000259.mp4
Now, we pass account change events to other open frames, such that they can update their UI accordingly with changed accounts.