Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix formatting of add network ui #5781

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Aug 19, 2024

Try out Leather build e7b5771Extension build, Test report, Storybook, Chromatic

This PR adjusts the Add Network UI as per comments in #5735

@kyranjamie
Copy link
Collaborator

We renamed the organisation to leather-io so your commit doesn't point to an issue

@pete-watters pete-watters force-pushed the fix/5735/add-network-ui branch from ee9edb8 to 1ce3034 Compare August 19, 2024 08:13
@pete-watters pete-watters force-pushed the fix/5735/add-network-ui branch from 1ce3034 to e7b5771 Compare August 19, 2024 08:21
@pete-watters
Copy link
Contributor Author

We renamed the organisation to leather-io so your commit doesn't point to an issue

Thanks 👍 thats a mistake from me - recycling commit messages.

I amended my commit message to be fix: fix formatting of add network ui, closes leather-io/issues#5735 but it seems like it's not linking properly still. Any ideas there?

@pete-watters pete-watters enabled auto-merge August 19, 2024 08:22
@pete-watters pete-watters added this pull request to the merge queue Aug 19, 2024
Merged via the queue into dev with commit 8a76b5f Aug 19, 2024
28 of 29 checks passed
@pete-watters pete-watters deleted the fix/5735/add-network-ui branch August 19, 2024 08:24
@markmhendrickson
Copy link
Collaborator

Let's add a (screenshot-based) integration test for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix formatting issues for network addition view
3 participants