Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show settings menu when session locked #5785

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Aug 19, 2024

Try out Leather build c2aaea5Extension build, Test report, Storybook, Chromatic

This PR:

@kyranjamie
Copy link
Collaborator

@pete-watters
Don't capitalise add network

illegal commit, not sure why linter doesn't pick this up

@pete-watters pete-watters force-pushed the fix/5777/locked-settings-sign-out branch 3 times, most recently from 54e2cb5 to 053bc83 Compare August 21, 2024 05:24
@pete-watters pete-watters linked an issue Aug 21, 2024 that may be closed by this pull request
@pete-watters pete-watters force-pushed the fix/5777/locked-settings-sign-out branch from 053bc83 to 840e675 Compare August 21, 2024 05:30
@pete-watters
Copy link
Contributor Author

@fbwoolf - can you please help check this when you have time? @kyranjamie raised some concerns with the initial implementation here but I have addressed them. Thanks! 🙇

@alter-eggo
Copy link
Contributor

I believe there is no sense in back btn when wallet is locked?
Screenshot 2024-08-21 at 12 59 02

@alter-eggo
Copy link
Contributor

also I believe we need to hide switch acc and lock items from menu
when try to switch acc I get such err (on the 2nd screenshot)
Screenshot 2024-08-21 at 12 59 57
Screenshot 2024-08-21 at 13 00 22

@pete-watters
Copy link
Contributor Author

I believe there is no sense in back btn when wallet is locked? Screenshot 2024-08-21 at 12 59 02

Thanks @alter-eggo - good idea. I've updated to not show this when the session is locked

@pete-watters
Copy link
Contributor Author

also I believe we need to hide switch acc and lock items from menu when try to switch acc I get such err (on the 2nd screenshot) Screenshot 2024-08-21 at 12 59 57 Screenshot 2024-08-21 at 13 00 22

Thanks @alter-eggo : I've updated it to hide both Switch Account and Lock if the wallet is already locked

@pete-watters pete-watters requested a review from fbwoolf August 21, 2024 12:51
@pete-watters pete-watters force-pushed the fix/5777/locked-settings-sign-out branch from b7aede2 to 6830c45 Compare August 21, 2024 13:42
@pete-watters pete-watters force-pushed the fix/5777/locked-settings-sign-out branch from 6830c45 to 2084d1e Compare August 21, 2024 15:24
@pete-watters pete-watters force-pushed the fix/5777/locked-settings-sign-out branch from 2084d1e to c2aaea5 Compare August 21, 2024 15:26
@pete-watters pete-watters enabled auto-merge August 21, 2024 15:26
@pete-watters pete-watters added this pull request to the merge queue Aug 21, 2024
Merged via the queue into dev with commit b43cf8b Aug 21, 2024
29 checks passed
@pete-watters pete-watters deleted the fix/5777/locked-settings-sign-out branch August 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants