Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename dialog as sheet, closes ref leather-io/issues#268 #5816

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: rename dialog as sheet, closes ref leather-io/issues#268 #5816

merged 1 commit into from
Aug 27, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Aug 27, 2024 •
edited
Loading

Try out Leather build 6734fd8 — Extension build, Test report, Storybook, Chromatic

This PR renames Dialog as Sheet as per https://github.com/leather-io/issues/issues/268

It builds upon the UI library update here

@pete-watters pete-watters self-assigned this Aug 27, 2024
@pete-watters pete-watters added the needs:refactoring Tech debt, developer experience, testing, etc. label Aug 27, 2024
@pete-watters pete-watters marked this pull request as ready for review August 27, 2024 14:00
@pete-watters pete-watters added the enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives label Aug 27, 2024
@pete-watters pete-watters added this pull request to the merge queue Aug 27, 2024
Merged via the queue into dev with commit ec64755 Aug 27, 2024
31 checks passed
@pete-watters pete-watters deleted the fix/268/refactor-dialog-to-sheet branch August 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

@alter-eggo alter-eggo Awaiting requested review from alter-eggo

@edgarkhanzadian edgarkhanzadian Awaiting requested review from edgarkhanzadian

Assignees

@pete-watters pete-watters

Labels
enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives needs:refactoring Tech debt, developer experience, testing, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pete-watters @fbwoolf