Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve open API and add tests, ref leather-io/issues#5800 #5835

Merged
merged 1 commit into from
Sep 3, 2024
Merged

chore: improve open API and add tests, ref leather-io/issues#5800 #5835

merged 1 commit into from
Sep 3, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Sep 3, 2024 •
edited by leather-bot
Loading

Try out Leather build 0fbb526 — Extension build, Test report, Storybook, Chromatic

This PR improves the open API to:

  • resolve promises on success
  • add test coverage

@pete-watters pete-watters force-pushed the chore/5800/open-wallet-api-tests branch from e16c9d6 to da22b9a Compare September 3, 2024 08:00
kyranjamie
kyranjamie reviewed Sep 3, 2024
View reviewed changes
src/background/messaging/rpc-methods/open.ts Outdated Show resolved Hide resolved
src/background/messaging/rpc-methods/open.ts Outdated Show resolved Hide resolved
src/shared/rpc/methods/open-wallet.ts Outdated Show resolved Hide resolved
src/background/messaging/rpc-methods/open.ts Outdated Show resolved Hide resolved
@kyranjamie
Copy link
Collaborator

I wonder if this flow should ask user permission? https://gamma.io wants to open Leather

@pete-watters pete-watters force-pushed the chore/5800/open-wallet-api-tests branch from da22b9a to 0fbb526 Compare September 3, 2024 08:22
@pete-watters pete-watters marked this pull request as ready for review September 3, 2024 08:35
@pete-watters
Copy link
Contributor Author

I wonder if this flow should ask user permission? https://gamma.io wants to open Leather

Is it OK to add a new task for this and schedule it soon or do it in #5821?

I can update the logic so it's similar to getAddresses and uses useAppPermissions .

There was pressure to do this to not block .locker so I wanted to get something out but we can refine and improve if / when we hear back from the requesters

@pete-watters pete-watters added this pull request to the merge queue Sep 3, 2024
@pete-watters pete-watters linked an issue Sep 3, 2024 that may be closed by this pull request
Open the Leather extension programmatically (API needed) #5800
Closed
@pete-watters pete-watters self-assigned this Sep 3, 2024
Merged via the queue into dev with commit 9d52d9e Sep 3, 2024
30 checks passed
@pete-watters pete-watters deleted the chore/5800/open-wallet-api-tests branch September 3, 2024 08:47
@pete-watters pete-watters mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees

@pete-watters pete-watters

Labels
area:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open the Leather extension programmatically (API needed)
2 participants
@pete-watters @kyranjamie