fix: refactor add network to use card footer, closes leather-io/issue… #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
approved these changes
Sep 6, 2024
|
Everything looks good except the padding inside the page which Im not sure it's related to container. Ideally the padding on the extension pop up should be 24px left and right. Right now it looks like 32px or 40px? 
|
pete-watters
force-pushed
the
fix/313/add-network-ui
branch
from
8927f57 to
1d44909
Compare
I updated it, thanks! |
|
LGTM |
pete-watters
force-pushed
the
fix/313/add-network-ui
branch
2 times, most recently
from
b4a8d1e to
a72705e
Compare
pete-watters
force-pushed
the
fix/313/add-network-ui
branch
from
a72705e to
f928219
Compare
|
@pete-watters ready to merge? |
It is but I can't merge it as we have a test failing in the CI (for all branches) that we need to investigate and fix. It relates to #5854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issues addresses a bug raised in https://github.com/leather-io/issues/issues/313. I've made some adjustments here to use the CardFooter so that it matches up with the previous Add a network sheet.
Area.mp4