Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: currency model imports #5859

Merged
merged 2 commits into from
Sep 20, 2024
Merged

refactor: currency model imports #5859

merged 2 commits into from
Sep 20, 2024

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Sep 17, 2024

Try out Leather build 57167dcExtension build, Test report, Storybook, Chromatic

I made changes in the models pkg that need to be updated here.

@fbwoolf fbwoolf requested a review from alter-eggo September 17, 2024 14:15
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Sep 17, 2024

I also had to add two resolutions here for security audit failtures ...again with storybook addons.

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this naming change @fbwoolf, 1% more consistent 🧘🏼‍♂️

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Sep 17, 2024

It appears the failing send btc tests are hitting this...

{calcMaxSpend(props.values.recipient, utxos).spendableBitcoin.toNumber() > 0 ? (

When I try to send btc on testnet, I'm getting a wrong insufficient balance error...
Screenshot 2024-09-17 at 11 19 29 AM copy

Issue made here: #5854

cc @alter-eggo

@pete-watters
Copy link
Contributor

I also had to add two resolutions here for security audit failtures ...again with storybook addons.

Thanks @fbwoolf . I had to add some resolutions for storybook lately too. Maybe we can consider getting rid of storybook in the extension now and just using it in the UI libs?

@kyranjamie kyranjamie force-pushed the refactor/currency-type branch from 0dd5f99 to 57167dc Compare September 20, 2024 09:21
@kyranjamie kyranjamie added this pull request to the merge queue Sep 20, 2024
Merged via the queue into dev with commit d4c8b48 Sep 20, 2024
30 checks passed
@kyranjamie kyranjamie deleted the refactor/currency-type branch September 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants