Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update wbip004 method name, closes #5866 #5867

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

alexp3y
Copy link
Contributor

@alexp3y alexp3y commented Sep 20, 2024

Try out Leather build f7aa920Extension build, Test report, Storybook, Chromatic

This PR updates the method name "sentTransfer" to "sendTransfer" on the WBIP004 provider registration object in array window.btc_providers.

Ensures the registered method names match the actual RPC methods available via LeatherProvider.

@alexp3y alexp3y self-assigned this Sep 20, 2024
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex.

Who could've possibly made this typo... 🙄

@alexp3y alexp3y added this pull request to the merge queue Sep 20, 2024
Merged via the queue into dev with commit d0873e8 Sep 20, 2024
31 checks passed
@alexp3y alexp3y deleted the refactor/rename-wbip004-method branch September 20, 2024 13:44
@pete-watters
Copy link
Contributor

Nice work @alexp3y 👏 great to get your first PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update method name in WBIP004 discovery array object to match Leather API
3 participants