feat: convert rpc-methods to @leather.io/rpc types #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Yeah we should use RPC in extension. Think you're finding some of the things I was trying to fix, e.g. #5963
camerow
force-pushed
the
will/leather-rpc
branch
from
325f6f8 to
764ff7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kyranjamie Doing the
openSwapwork lead me down a bit of a rabbit hole, curious if it was actually intentional to not use@leather.io/rpcin extension?As I worked on this I noticed all the discrepancies between the API that is running in
LeatherProviderand what we say we'll do in@leather.io/rpcso I went ahead and updated the types...happy to bail out of this if I was a bit overzealous.This PR would rely on changes made here: https://github.com/leather-io/mono/pull/732/files