-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sponsored sbtc txns #6012
Conversation
interface SbtcSponsorshipVerificationResult { | ||
isVerifying: boolean; | ||
result: SbtcSponsorshipEligibility | undefined; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be discriminating union to help types when consuming?
interface SbtcSponsorshipVerificationResult { | |
isVerifying: boolean; | |
result: SbtcSponsorshipEligibility | undefined; | |
} | |
interface SbtcSponsorshipVerificationResultPending { | |
isVerifying: false; | |
} | |
interface SbtcSponsorshipVerificationResultVerified { | |
isVerifying: true; | |
result: SbtcSponsorshipEligibility; | |
} | |
type SbtcSponsorshipVerificationResult = SbtcSponsorshipVerificationResultPending | SbtcSponsorshipVerificationResultVerified; |
1f4b1a0
to
745684f
Compare
745684f
to
618ec36
Compare
@alexp3y is this testable with regular testnet? |
@markmhendrickson If you bridged testnet sbtc, txs from that address should work. The current testnet API doesn't have whitelisted contract support, but any sbtc swaps / sbtc post-condition txs would work in theory. Will try to set up a separate test API now that works around not having testnet sbtc. |
Swaps need testing on mainnet, and testnet API will get updated to allowlist enroll transaction for further testing |
85c4e68
to
7229768
Compare
298b9e3
to
59b905c
Compare
bbabe49
to
c4c0b7a
Compare
c4c0b7a
to
d60d444
Compare
59b905c
to
625b03d
Compare
a9adf16
to
31439ed
Compare
@alexp3y I rebased this into one commit, but I didn't realize that would remove you as a contributor. Can you review the code and make a small commit change before I merge this into the feature branch? You can squash everything into a commit you make and push up? |
31439ed
to
945207c
Compare
945207c
to
dc94e36
Compare
12d6e50
to
e618ccf
Compare
@fbwoolf @kyranjamie @markmhendrickson Ready for review. Covers sponsorships for both contract calls and swaps. Need to change API URL config once in place. Will update shortly once updated testing APIs are online.
@fbwoolf I removed the swap sponsorship condition checks from here (other than feature flag enabled) to rely solely on the API verification rules (gives us a bit more flexibility in updating sponsorship rules).