feat: sbtc token support #6014
Closed
feat: sbtc token support #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
We would only need to add 'mainnet' to the wallet config to show the promo card. |
camerow
reviewed
Dec 17, 2024
| const network = useCurrentNetwork(); | ||
|
|
||
| return useMemo(() => { | ||
| const displayPromoCardOnNetworks = (sbtc as any)?.showPromoLinkOnNetworks ?? []; |
There was a problem hiding this comment.
Do we have to cast as any? I made a comment I deleted thinking this was for all config properties, but I see below we can have some type safety on sbtc.enabled - would love to see that here too for refactorability and not surprising ourselves with small avoidable bugs in the future.
camerow
reviewed
Dec 17, 2024
| @@ -70,11 +70,11 @@ function useCreateSwapAsset(address: string) { | |||
| ...swapAsset, | |||
| balance: availableBalance ?? createMoney(0, token.symbol, token.tokenDecimals), | |||
| marketData: availableBalance | |||
| ? priceAsMarketData(swapAsset.principal, availableBalance.symbol) | |||
| : priceAsMarketData(swapAsset.principal, token.symbol), | |||
| ? getTokenMarketData(swapAsset.principal, availableBalance.symbol) | |||
There was a problem hiding this comment.
Aren't token.symbol and availableBlance.symbol the same? Thinking that because of this logic:
const availableBalance = sip10Tokens.find(
sip10Token => getPrincipalFromContractId(sip10Token.info.contractId) === token.tokenContract
)?.balance.availableBalance;
Where the contract info is matched on the token.tokenContract
camerow
approved these changes
Dec 17, 2024
|
Closing in favor of feature branch #5991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates out some of the initial work for sBTC support:
cc @kyranjamie as this was mostly your work