fix: endless loading in ledger mode #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
force-pushed
the
fix/endless-loading
branch
from
d163068 to
e8f92cd
Compare
alter-eggo
commented
Dec 17, 2024
| @@ -69,7 +69,7 @@ export function AccountCard({ | |||
| </Flex> | |||
| <Flex flexDir={{ base: 'column', md: 'row' }} justify="space-between"> | |||
| <Box mb="space.05" mt="space.04"> | |||
| <SkeletonLoader width="200px" height="38px" isLoading={isLoadingBalance}> | |||
| <SkeletonLoader width="200px" height="46px" isLoading={isLoadingBalance}> | |||
There was a problem hiding this comment.
to prevent slight "jump"
alter-eggo
requested review from
kyranjamie,
pete-watters and
tigranpetrossian
pete-watters
approved these changes
Dec 17, 2024
tigranpetrossian
approved these changes
Dec 17, 2024
kyranjamie
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g when in btc only ledger mode, there is no stacks address, so stx balance request is always in
pendingstatus, so we show skeleton loader instead of total balancewill write test in sep pr
