fix: inscriptions settings btn and available balance #6050
+40
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
requested review from
tigranpetrossian,
fbwoolf and
edgarkhanzadian
fbwoolf
reviewed
Dec 27, 2024
| @@ -21,7 +21,7 @@ import { PrivateTextLayout } from '@app/components/privacy/private-text.layout'; | |||
| import { BasicTooltip } from '../tooltip/basic-tooltip'; | |||
|
|
|||
| const availableBalanceTooltipLabel = | |||
| 'Total balance minus outbound transfers, protected collectibles and uneconomical UTXOs.'; | |||
| 'Total balance minus locked amounts, outbound transfers, protected collectibles and uneconomical UTXOs'; | |||
There was a problem hiding this comment.
I'm not sure the . should have been removed here. I do think we typ include in other tooltips?
There was a problem hiding this comment.
@markmhendrickson I also think you meant we need to actually deduct first from the new available balance at top?
fbwoolf
approved these changes
Dec 27, 2024
|
I initially approved this, but I'm not confident adding |
fbwoolf
changed the title
|
EDIT: Nvm, this was me and my .env file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr fixes: