fix: apply queries changes #155
Conversation
edgarkhanzadian
requested review from
kyranjamie,
pete-watters,
fbwoolf and
alter-eggo
WalkthroughThe recent update simplifies the logic for determining if Runes are enabled by replacing Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/query/src/bitcoin/runes/runes-ticker-info.query.ts (1 hunks)
Additional Context Used
Biome (1)
packages/query/src/bitcoin/runes/runes-ticker-info.query.ts (1)
4-5: Some named imports are only used as types.
Additional comments not posted (1)
packages/query/src/bitcoin/runes/runes-ticker-info.query.ts (1)
14-19: The integration ofisDefinedanduseRunesEnabledin the query logic is well-implemented. It ensures that queries are only enabled when necessary, improving performance and preventing potential errors.
| import { useLeatherNetwork } from '../../leather-query-provider'; | ||
| import { RuneBalance, type RuneTickerInfo, useBitcoinClient } from '../bitcoin-client'; |
There was a problem hiding this comment.
Consider importing RuneBalance and RuneTickerInfo using TypeScript's type-only import to prevent them from being included in the JavaScript bundle if they are only used as types.
- import { RuneBalance, type RuneTickerInfo, useBitcoinClient } from '../bitcoin-client';
+ import { useBitcoinClient } from '../bitcoin-client';
+ import type { RuneBalance, RuneTickerInfo } from '../bitcoin-client';Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| import { useLeatherNetwork } from '../../leather-query-provider'; | |
| import { RuneBalance, type RuneTickerInfo, useBitcoinClient } from '../bitcoin-client'; | |
| import { useLeatherNetwork } from '../../leather-query-provider'; | |
| import { useBitcoinClient } from '../bitcoin-client'; | |
| import type { RuneBalance, RuneTickerInfo } from '../bitcoin-client'; |
|
Going to merge this bc I need to see Runes in the extension. |
Apply queries changes made in this PR: leather-io/extension#5439
Summary by CodeRabbit
New Features
Refactor
useConfigRunesEnabledwithuseRunesEnabled.