fix: dialog header height + refactor dialog footer #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
force-pushed
the
fix/5248/popup-ui
branch
from
137e3b8 to
b31599f
Compare
pete-watters
changed the title
pete-watters
force-pushed
the
fix/5248/popup-ui
branch
from
b31599f to
acd312c
Compare
pete-watters
requested review from
fabric-8,
fbwoolf,
alter-eggo and
edgarkhanzadian
and removed request for
fabric-8
alter-eggo
approved these changes
Aug 21, 2024
edgarkhanzadian
approved these changes
Aug 21, 2024
pete-watters
force-pushed
the
fix/5248/popup-ui
branch
from
acd312c to
d02f267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Dialogto locate theFootercomponent local to it and avoid using it in the extension