base-files: fix shell scope error for the default LED brightness

This fixes "sh: write error: Invalid argument" for all default!=1 LEDs as an empty $brightness was used. Setting up LEDs via luci also now works again. Fixes cbdfd03: "base-files: add option to set LED brightness" Signed-off-by: Andre Heider <[email protected]> Link: openwrt/openwrt#17269 Signed-off-by: John Crispin <[email protected]>
lede-project · Dec 14, 2024 · 3c7134f · 3c7134f
1 parent 15e173b
commit 3c7134f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/package/base-files/files/etc/init.d/led b/package/base-files/files/etc/init.d/led
@@ -106,9 +106,10 @@ load_led() {
 		[ "$default" = 0 ] &&
 			echo 0 >/sys/class/leds/${sysfs}/brightness
 
-		[ $default = 1 ] &&
-			[ -z "$brightness" ] && brightness=$(cat /sys/class/leds/${sysfs}/max_brightness)
-			echo $brightness > /sys/class/leds/${sysfs}/brightness
+		[ "$default" = 1 ] && {
+			[ -z "$brightness" ] && brightness="$(cat /sys/class/leds/${sysfs}/max_brightness)"
+			echo "$brightness" > /sys/class/leds/${sysfs}/brightness
+		}
 
 		led_color_set "$1" "$sysfs"