Skip to content

Commit

Permalink
kernel: generic: tg3: Fix DMA allocations on 57766 devices
Browse files Browse the repository at this point in the history
At the request of rsalvaterra, add this patch to fix an issue
affecting tg3 ethernet interfaces[1].

1. openwrt/openwrt#17271 (comment)

Tested-by: Rui Salvaterra <[email protected]>
Signed-off-by: John Audia <[email protected]>
Link: openwrt/openwrt#17282
Signed-off-by: Hauke Mehrtens <[email protected]>
(cherry picked from commit a3c484c)
  • Loading branch information
graysky2 authored and hauke committed Dec 16, 2024
1 parent 2860245 commit 6d0d4ce
Showing 1 changed file with 31 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
From f992b15965177e2f280fb6f41f292214f9a6f8d5 Mon Sep 17 00:00:00 2001
From: Pavan Chebbi <[email protected]>
Date: Tue, 10 Dec 2024 03:28:31 -0800
Subject: [PATCH] tg3: Fix DMA allocations on 57766 devices

The coherent DMA mask of 31b may not be accepted if
the DMA mask is configured to use higher memories of
64b. Set the DMA mask also to lower 32b for 57766
devices.

Fixes: 614f4d166eee ("tg3: Set coherent DMA mask bits to 31 for BCM57766 chipsets")
Reported-By: Rui Salvaterra <[email protected]>
Signed-off-by: Pavan Chebbi <[email protected]>
---
drivers/net/ethernet/broadcom/tg3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -17731,8 +17731,10 @@ static int tg3_init_one(struct pci_dev *
} else
persist_dma_mask = dma_mask = DMA_BIT_MASK(64);

- if (tg3_asic_rev(tp) == ASIC_REV_57766)
+ if (tg3_asic_rev(tp) == ASIC_REV_57766) {
+ dma_mask = DMA_BIT_MASK(32);
persist_dma_mask = DMA_BIT_MASK(31);
+ }

/* Configure DMA attributes. */
if (dma_mask > DMA_BIT_MASK(32)) {

0 comments on commit 6d0d4ce

Please sign in to comment.