Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rosteritem definition #500

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix rosteritem definition #500

merged 1 commit into from
Jan 11, 2024

Conversation

agnauck
Copy link
Contributor

@agnauck agnauck commented Jan 11, 2024

On the RosterItem type:

  • the pending (ask) property is missing
  • approved property should be preApproved

see also:

stanza/src/protocol/rfc6121.ts

Lines 110 to 111 in f20155b

pending: attribute('ask'),
preApproved: booleanAttribute('approved'),

@legastero
Copy link
Owner

Thanks! I'll get this published later today.

@legastero legastero merged commit 85e484d into legastero:master Jan 11, 2024
4 checks passed
@legastero
Copy link
Owner

12.19.1 out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legastero legastero legastero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnauck @legastero