Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache poetry itself #558

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Cache poetry itself #558

merged 2 commits into from
Sep 12, 2024

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Sep 11, 2024

  • Cache pip use base to not reinstall poetry on every job.
  • Fix for macos which was using python from runner instead of provided.

@KapJI KapJI added the github structure Pull requests that update Github actions/workflow code label Sep 11, 2024
@KapJI KapJI force-pushed the faster-poetry branch 19 times, most recently from 2543cd8 to 2603c8a Compare September 11, 2024 22:19
@KapJI KapJI changed the title Don't install pipx again Cache pipx and poetry installation Sep 11, 2024
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks quite complex 😅
why do we not just use good old pip? it's slower - yes, but get's the job done in a lot simpler fashion with less dependencies to manage.
rye/uv is also an option

@KapJI
Copy link
Collaborator Author

KapJI commented Sep 12, 2024

I guess at this point it's no longer about usefulness but rather about learning how to make CI the most efficient 😅

I don't think we need pipx here actually, I can try to remove it. This is still WIP.

uv looks interesting, we can try to use it instead of poetry.

@KapJI KapJI force-pushed the faster-poetry branch 5 times, most recently from 34da5ff to 7bfa8bd Compare September 12, 2024 11:20
@KapJI KapJI changed the title Cache pipx and poetry installation Cache poetry itself Sep 12, 2024
@KapJI
Copy link
Collaborator Author

KapJI commented Sep 12, 2024

Good enough now for this PR. Other improvements will be done in subsequent PRs.

Windows build job is 30% faster now (51s->37s)

@KapJI KapJI merged commit cac4282 into leikoilja:master Sep 12, 2024
7 checks passed
@KapJI KapJI deleted the faster-poetry branch September 12, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github structure Pull requests that update Github actions/workflow code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants