legit: write commit message in a buffer #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good change. |
|
It is ready for those who want to keep testing lem/legit, but by looking at it I see a couple inline tests that you might not like :D (I like them… these will also be useful again shortly) |
|
Yeah, I think the inline comment are not bad. |
vindarel
force-pushed
the
vindarel/lem-real-commit-message
branch
from
d0afe8e to
b0e00ab
Compare
|
oh thanks. Added. |
vindarel
force-pushed
the
vindarel/lem-real-commit-message
branch
from
b0e00ab to
c244ba9
Compare
|
hello, ping? |
cxxxr
reviewed
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can only write one-line commit messages in Lem/legit :S This improves the situation, we create a special buffer to write commit messages.
I only tested this evening while working on it.