Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the cursor-type to underline for vi-operator + the color of vi-insert cursor now respects the default cursor color #1661

Merged

Conversation

sakurawald
Copy link
Contributor

@sakurawald sakurawald commented Dec 1, 2024

Solve part of the issue: #1648

This commit contains changes:

  • The color of cursor in vi-insert-mode should respect the set default cursor color.
  • The cursor-type for vi-operator should be underline, e.g. the ciw command.

It will be better, after the bug of drawing of underline and bar cursor type in sdl2 version is fixed. The underline and bar cursor tpe is drawn well in ncursrs version.

In sdl2 version:

  1. The underline cursor-type will over-draw the character under caret.
  2. The bar cursor-type will over-draw the character under caret in some cases, taken "LEM" string for example.

…of vi-insert cursor now respects the default cursor color
@cxxxr cxxxr merged commit 9adbfe5 into lem-project:main Dec 1, 2024
1 of 2 checks passed
@sakurawald sakurawald deleted the fix-vi-cursor-type-for-vi-operator branch December 4, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants