Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ban mouse click event in popup-window made by popup-message function. #1693

Merged

Conversation

sakurawald
Copy link
Contributor

@sakurawald sakurawald commented Dec 9, 2024

To close issue: #1686

This commit does:

  1. Add a new parameter clickable to window. (When clickable = nil, the mouse clicking event will be ignore for this window. However, thw mouse hover event and mouse scrolling event can still be received for that window)
  2. Made the popup-window made by popup-message now un-clickable.

@sakurawald sakurawald changed the title Ban mouse click event in popup-window maded by popup-message function. Ban mouse click event in popup-window made by popup-message function. Dec 9, 2024
Copy link
Contributor

@jfaz1 jfaz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe modify the comment to be a bit clearer:

;; NOTE: Block mouse clicks on popup windows to prevent them from gaining focus.
;; If a popup window gains focus, it becomes the only active window in the window-tree,
;; which prevents Lem from being able to close it.
;; Mouse scrolling remains enabled since popup windows are used for displaying text content.

@sakurawald
Copy link
Contributor Author

LGTM, maybe modify the comment to be a bit clearer:

;; NOTE: Block mouse clicks on popup windows to prevent them from gaining focus.
;; If a popup window gains focus, it becomes the only active window in the window-tree,
;; which prevents Lem from being able to close it.
;; Mouse scrolling remains enabled since popup windows are used for displaying text content.

Modified.

@sakurawald sakurawald changed the title Ban mouse click event in popup-window made by popup-message function. fix: ban mouse click event in popup-window made by popup-message function. Dec 9, 2024
@cxxxr cxxxr merged commit 772d145 into lem-project:main Dec 9, 2024
2 checks passed
@cxxxr
Copy link
Member

cxxxr commented Dec 9, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants