Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make makefile applicable. #1717

Merged
merged 1 commit into from
Dec 30, 2024
Merged

make makefile applicable. #1717

merged 1 commit into from
Dec 30, 2024

Conversation

snmsts
Copy link
Member

@snmsts snmsts commented Dec 27, 2024

No description provided.

@snmsts
1. Remove sudo from install. sudo is not standard command and some pl…
9a83265 
…atform/installation might not have it.

   User should explicitly run `sudo make install`
2. Separate install with install and install-bin. gtk desktop related thing are not necessary in some case.
3. Factor out the common options into $(LISP)
@jfaz1
Copy link
Contributor

jfaz1 commented Dec 28, 2024

I agree with the changes, but sudo make install doesn't find qlot; is there an easy way to have it find it? Will probably have to update the docs.

@snmsts
Copy link
Member Author

snmsts commented Dec 29, 2024

If you intend to build on root account you should setup qlot on root account as well.
I believe it is not good idea to encourage suspicious activity(build) on privileged user.

how about.

make;sudo make install-bin

or

make lem;sudo make install

jfaz1
jfaz1 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@jfaz1 jfaz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a disclaimer to the docs, but this makes sense, thanks!

@cxxxr cxxxr merged commit 97526c7 into lem-project:main Dec 30, 2024
2 checks passed
@snmsts snmsts deleted the edit-makefile branch December 30, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaz1 jfaz1 jfaz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snmsts @jfaz1 @cxxxr