Updated logbook function #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated logbook_entries function to fetch climb-uuid, updated the csv_output to clean the climb_uuid before export. changed auth type to allow username/password or user_id/token
properly named climb_uuid to climb_angle_uuid to be precise, because uuid + angle are already merged
lemeryfertitta
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Thanks @gardaholm! This looks much better. Just a few small changes requested and then I will package this up and deploy it in a new version.
adding comment, as suggested Co-authored-by: Luke Emery-Fertitta <[email protected]>
as suggested Co-authored-by: Luke Emery-Fertitta <[email protected]>
Moved the fallback login information for username/passwored from logbook_entries() to handle_logbook_command()
|
hope this is fine now :) |
lemeryfertitta
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version to allow basic stats functionality as written in lemeryfertitta/Climbdex#55
logbook_entriesto allow AUTH with username/password and user_id/tokenboard,angle,climb_name,date,logged_grade,displayed_grade,difficulty,tries,is_mirror,sessions_count,tries_total,is_repeat,is_ascent,comment