convert chr to bytes #31

teadur · 2020-04-19T12:57:24Z

#19 not sure if it actually works but atleast does not fail with exception.

…ame__

fix includes of PyGtk3 packages to conform to PyGtk3 syntax fix Gdk includes and names moved to new namespaces in Gtk3

…ebug network traffic

…gs implicitly

…other parameter

* test instantiating a SlskProtoThread * added recording of login process * added recording of search process * subdirectory structure for multiple tasks * Test for various function calls in SlskProtoThread.run() * load saved socket traffic, but don't do anything with it yet * added test that FileSearch objects are encoded correctly * rebased on branch python3

* Naming a variable after a builtin type probably seemed like a good idea at the time * Use bytes instead of string where appropriate * Update string.join("...", ...) usage to "...".join(...)

* Fix flake8 warnings * Mark remaining flake8 warnings with noqa comment * Update pipelines Co-authored-by: droserasprout <[email protected]> Co-authored-by: Lev Gorodetskiy <[email protected]>

…s and char/bytes errors

lene and others added 30 commits March 2, 2020 10:57

print a warning instead of failing for (still mysterious) missing __n…

9a95ea3

…ame__

python 3 expects byte strings to be declared explicitly

692eca6

ignore PyCharm and emacs files

459b9be

fix Gdk includes and names moved to new namespaces in Gtk3

fef307e

fixed more errors

6b17c48

fixed more errors - UI now appears

0e027a4

4AM, time for sleep. Still not connecting, but slow progress.

1324cb2

replaced usage of obsolete dircache module

d49cacf

ignore broken links instead of failing

03462dc

Gtk column definitions are now strict. Fixed column value.

3cf604b

one more instance where byte streams need to be explicitly declared

1329198

fix more renamed Gtk constants

32c4b2e

debug network layer

c02d2cc

fix more(2) renamed Gtk constants

f32fa76

debug++

a407bd7

Downgraded needed Python to 3.6

7a85ecb

added basic Dockerfile

37ef122

ignore PyCharm and emacs files and .venv

78639dd

fix imports to use Python3 versions of needed modules

d70181f

fix includes of PyGtk3 packages to conform to PyGtk3 syntax fix Gdk includes and names moved to new namespaces in Gtk3

rename Gtk constants so they follow the Gtk3 schema

ef41696

replaced usage of obsolete dircache module

13a246b

fix parsing configs raising "__name__" KeyError

9ed1fd0

Running Python 2 and 3 versions in docker containers and compare to d…

efe1839

…ebug network traffic

Python 3 needs explicit handling of bytes instead of converting strin…

2d94f65

…gs implicitly

GitHub action for testing and linting (lene#6)

ebc4bc2

getting list of room succeeds

354d1fe

convert messages from bytes to str in the message __init__()

b602b50

Private chat now basically works

b3edd31

chat rooms mostly work

f269152

don't fail when trying to decode invalid UTF-8

e0b3a21

Lene Preuss and others added 11 commits April 19, 2020 13:55

File search: updated obsolete Gtk usage

66f0ad2

Another bytes/string incompatibility bug

b3bfc99

instead of figuring out who calls CellDataFunc() wrongly, just add an…

18d9e30

…other parameter

2 to 3 migration issues (bytes, str member functions, sys.maxsize)

6508556

Feedback from @toofar's code review

5027c69

* Naming a variable after a builtin type probably seemed like a good idea at the time * Use bytes instead of string where appropriate * Update string.join("...", ...) usage to "...".join(...)

Make flake8 run, thanks @droserasprout (lene#24)

38f3c57

* Fix flake8 warnings * Mark remaining flake8 warnings with noqa comment * Update pipelines Co-authored-by: droserasprout <[email protected]> Co-authored-by: Lev Gorodetskiy <[email protected]>

Fail CI and docker image startup on either linting or test failures

515947b

Modern pack_start() method requires four arguments

a4af2b9

Downloading folders works thanks to fixing more obsolete string usage…

0af8e89

…s and char/bytes errors

convert chr to bytes

a4a8e60

lene force-pushed the python3 branch from 0af8e89 to 572dd20 Compare April 19, 2020 13:07

teadur added 2 commits April 19, 2020 18:57

binary write to logfile, str username

0c4c2b1

fix sharedfiles calculation

de4e18f

teadur closed this Apr 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convert chr to bytes #31

convert chr to bytes #31

teadur commented Apr 19, 2020

convert chr to bytes #31

convert chr to bytes #31

Conversation

teadur commented Apr 19, 2020