Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chunked data #329

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: chunked data #329

merged 1 commit into from
Jan 22, 2025

Conversation

panuhorsmalahti
Copy link
Contributor

@panuhorsmalahti panuhorsmalahti commented Jan 21, 2025

  • Fixes regression in fix: Handle streaming for not chunked request #313, which caused the stream-impersonator to not send all bytes that are not part of the body or headers, which would caused chunked transfer encoding to break, as we need those extra bytes to specify the chunk sizes
  • The fix is to wait until headers are received, only parse the header bytes and then parse the rest of the bytes as normal
  • Adds regression test to ensure transfer encoding chunked works correctly

@panuhorsmalahti panuhorsmalahti force-pushed the chore/transfer-chunked-2 branch from fea5ac2 to d7f412b Compare January 22, 2025 08:33
@panuhorsmalahti panuhorsmalahti marked this pull request as ready for review January 22, 2025 08:39
@panuhorsmalahti panuhorsmalahti requested review from jakolehm and a team January 22, 2025 08:51
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panuhorsmalahti panuhorsmalahti merged commit 67f1e0a into main Jan 22, 2025
3 checks passed
@panuhorsmalahti panuhorsmalahti deleted the chore/transfer-chunked-2 branch January 22, 2025 09:05
@panuhorsmalahti panuhorsmalahti mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants