Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet ef commands #7

Open
strakamichal opened this issue Nov 19, 2020 · 3 comments · May be fixed by #8
Open

Add dotnet ef commands #7

strakamichal opened this issue Nov 19, 2020 · 3 comments · May be fixed by #8
Labels
enhancement New feature or request

Comments

@strakamichal
Copy link

Hi,
it would be nice if you can add EF commands for Entity Framework Core. I think about forking your repo, but I'm not the typescript guy...

The most used commands:

  • dotnet ef migrations add {{migration name}}
  • dotnet ef migrations remove
  • dotnet ef database update {{migration name - optional}}

Full reference: https://docs.microsoft.com/en-us/ef/core/cli/dotnet

I think extension should firstly prompt for EF project (via your csproj selector) because these commands must be executed on a specified project.

Thank you for your time!

@leo-labs leo-labs added the enhancement New feature or request label Nov 19, 2020
@strakamichal
Copy link
Author

Hi, I already downloaded your source code and try to add EF commands. It's working (from my point of view). I'm ready to publish it as a forked extension (mentioning you as the original author), but If you will add these features to your extension then I don't have to fork it.

I uploaded my source code.
vscode-dotnetef.zip

Is there another better way how to propose my changes? I'm an open-source newbie. Thanks.

@leo-labs
Copy link
Owner

@strakamichal Sounds great. Thanks for the contribution. I am happy to include EF core commands in general into the extension.

It's best if you fork this repository, push your changes on a new feature branch in your fork and open a pull request against my repository. There is lots of documentation available how to do this, see e.g. https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Once you have done that I can easily review your changes.

@strakamichal
Copy link
Author

@leo-labs OK, I will do the fork and pull request. Thanks!

@leo-labs leo-labs linked a pull request Nov 27, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants