Adding EF Core commands #8
Conversation
| @@ -0,0 +1,1231 @@ | |||
| { | |||
There was a problem hiding this comment.
Sorry, it's not documented, but i've used yarn and not npm. Yarn uses yarn.lock so this package-lock.json is not needed
| @@ -1,95 +1,121 @@ | |||
| { | |||
| "name": "dotnet", | |||
There was a problem hiding this comment.
@strakamichal Can you go over the PR again and make sure that your line ending settings are correct in git and that your patches do not change every line ending even if they do not touch the file?
There was a problem hiding this comment.
Also please check that you do not do reformatting :)
| } | ||
| }); | ||
| outputChannel.show(); | ||
| } |
There was a problem hiding this comment.
Please make also sure that there is a newline at the end of each file
| async () => runAndshowErrorAsMessage(removeMigration, true))); | ||
| context.subscriptions.push(vscode.commands.registerCommand('extension.dotnet.ef.database.update', | ||
| async () => runAndshowErrorAsMessage(updateDatabase, true))); | ||
| context.subscriptions.push(vscode.commands.registerCommand('extension.dotnet.ef.dbcontext.info', |
There was a problem hiding this comment.
I am not sure about the list and info commands. I do not have them currently for dotnet, mainly because they only print output. I want to think a little bit about that, but do you really use both and when?
| return stdout.toString('utf8').split(/\r?\n/); | ||
| } else { | ||
| return []; | ||
| } | ||
| } catch(e) { |
There was a problem hiding this comment.
this is e.g. an unnecessary formatting change
Hi,
I added new commands for Entity Framework CLI (dotnet ef).
New commands
extension.dotnet.ef.migrations.add
extension.dotnet.ef.migrations.remove
extension.dotnet.ef.migrations.list
extension.dotnet.ef.database.update
extension.dotnet.ef.dbcontext.info
There are some formatting issues on my side which result in a completely changed package.json - in real I changed just description, activation events, and commands section.