-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin goals back to the generated site. #213
Add plugin goals back to the generated site. #213
Conversation
Apparently, after some version that I was unable to determine, maven-plugin-plugin stopped performing reporting duties for the site generation, being replaced by maven-plugin-report-plugin. The Plugin documentation guide also confirms that maven-plugin-report-plugin is the plugin to use to generate the goals documentation. So I replaced one with the other. I also added the index page to the site reports, which I think was missing. Do let me know if any further clarification is required. |
Please don't merge this yet, as I think the navigation sidebar is lacking a link to the mojo documentation. |
b273eb0
to
b5fe437
Compare
b5fe437
to
cb68f5d
Compare
So, to summarize: this PR fixes the site generation by upgrading the site plugin descriptor and related reporting plugins. Since the dependency ecj has relocated to the groupId org.eclipse.jdt I changed those references. tomcat-jasper 10, which this plugin is referencing, is also pulling from org.eclipse.jdt:ecj. I did not find any need to override the version being pulled by tomcat-jasper, especially because the newest version no longer supports Java 11, so I decided to stick with the version being pulled by tomcat-jasper (3.33.0). People that wish to generate bytecode for newer JVMs can override the ECJ version, and I added that information to the howto page on the documentation site. Should be good to go now! |
Thanks for this. The website is updated. I actually haven't used JSPs since 2011 so I rely on outside contributors to keep this project alive. Are you interested in helping out maintaining it? |
Hi @leonardehrenfried I took a quick look at the issue and PR queue, but I don't see any major pending matters. Anything major you think needs to be tackled? On a separate note, I think that with #211 being merged, #24 can probably be closed as complete. |
Also, it would appear that the GitHub releases page is not showing the newer versions. I'm not sure how you were managing this before... I can't find any hints related to this in the master branch. |
@tcollignon , who was previously the co-maintained, created the releases manually. There is probably a github action that can do it automatically. That's also something you can do, if you are interested. |
Also added an index page, which I did not see in the generated site when I tested locally.