Doc for Summon events and getters #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Luashine/wc3-test-maps/tree/master/GetSummonedUnit
Hey lep, I was not sure where to put the per-event descriptions for the getters. I chose and think it's better to put what getters to use under event constants, because there's only one event but many different getters. It's easier for editing due to the one-to-many relationship rather than many-to-many if I were to put the comment to each getter. But for usability like in IDE it'd be better to mirror relevant lines to the getter function descriptions, like when exporting or showing this.