-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document text tag functions #138
Conversation
common.j
Outdated
|
||
@note The velocity adds a rendered offset to the text tag linearly related to the age of the text tag, i.e., doubled age means doubled offset. | ||
|
||
@note Doubled velocity means doubled offset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary? I think you kinda explained this above, if it didn't follow from the usual mathematical properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a separate statement. The offset is both linear to the age and linear to the velocity. It could also be that doubling velocity means four times the offset, for example.
offset = velocity * age * some constant that I do not know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do more investigations here later. On a resolution of 1920x1080, a velocity of 0.1 required approximately 15 seconds to cover that client width of 1920 in windowed mode. I have only played around with making the window smaller and changing the velocity (which both scaled the required time accordingly) and changing camera distance (which did not matter). I have not tried to change the resolution, physical screen or window mode etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK makes sense. I'd highlight this difference with @note Separately, doubled velocity means doubled offset too.
I think Tasyen is the one to ask here. It's most likely related to the adaptive HUD viewport when changing between 4:3 and 16:9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tasyen Maybe you know something about this.
Otherwise, I would set it ready for merge.
No description provided.