Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Possible multiple invocations of the INavigationAware interface methods #1116

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

textGamex
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When the View's DataContext is itself and the View implements the INavigationAware interface, the methods of the INavigationAware interface will be called twice.

Issue Number: #636

What is the new behavior?

  • fix this bug.

@textGamex textGamex requested a review from pomianowski as a code owner June 10, 2024 05:17
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request navigation Changes to navigation related controls. dotnet labels Jun 10, 2024
@pomianowski pomianowski self-assigned this Jun 10, 2024
@pomianowski pomianowski merged commit 9c55f37 into lepoco:development Jun 10, 2024
2 checks passed
@textGamex textGamex deleted the fix-bug branch June 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet navigation Changes to navigation related controls. PR Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants