Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add builds for arm64 #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastianwebber
Copy link

This PR adds support for arm builds.

@lesovsky
Copy link
Owner

Hi, thank you for PR, but I have some questions:

  1. Have you build pgcenter on ARM arch?
  2. Have you run tests and do the tests are passed?
  3. Have you check all functionality provided by pgcenter on ARM?

I am asking because I am not ARM-user and I don't have ARM devices - if some problems will occur on ARM users I unable to reproduce and handle bugs. Due to this I'd disinclined to take responsibility about proper work on platforms other than x86_64, and this is why there is only amd64 arch in build configuration.

It's quite easy to add new arch, but I must be completely sure that resulting binary will work correctly.

Now, about to PR, you added arm arch to goreleaser configuration. But besides of packages, this repo also has CI pipeline (Github Actions) and provides instructions for building docker images. If you want to implement ARM, you need to add CI instructions (see .github directory) for ARM, change existing docker builds instructions and add build instructions for amd64 and arm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants