Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove phantom stuff #3782

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove phantom stuff #3782

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
540afe3
remove phantom stuff
jimmywarting Mar 31, 2023
9c56e20
lint fix
jimmywarting Mar 31, 2023
8e00808
use deep clone
jimmywarting Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 21 additions & 27 deletions packages/less/src/less-browser/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ import ErrorReporting from './error-reporting';
import Cache from './cache';
import ImageSize from './image-size';

/**
* @param {Window} window
* @param {Object} options
*/
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved
export default (window, options) => {
const document = window.document;
const less = lessRoot();
Expand Down Expand Up @@ -46,42 +50,32 @@ export default (window, options) => {
return cloned;
}

// only really needed for phantom
function bind(func, thisArg) {
const curryArgs = Array.prototype.slice.call(arguments, 2);
return function() {
const args = curryArgs.concat(Array.prototype.slice.call(arguments, 0));
return func.apply(thisArg, args);
};
}

function loadStyles(modifyVars) {
const styles = document.getElementsByTagName('style');
let style;

for (let i = 0; i < styles.length; i++) {
style = styles[i];
for (let style of styles) {
if (style.type.match(typePattern)) {
const instanceOptions = clone(options);
instanceOptions.modifyVars = modifyVars;
const instanceOptions = {
...options,
jimmywarting marked this conversation as resolved.
Show resolved Hide resolved
modifyVars,
filename: document.location.href.replace(/#.*$/, '')
}

const lessText = style.innerHTML || '';
instanceOptions.filename = document.location.href.replace(/#.*$/, '');

/* jshint loopfunc:true */
// use closure to store current style
less.render(lessText, instanceOptions,
bind((style, e, result) => {
if (e) {
errors.add(e, 'inline');
less.render(lessText, instanceOptions, (err, result) => {
if (err) {
errors.add(err, 'inline');
} else {
style.type = 'text/css';
if (style.styleSheet) {
style.styleSheet.cssText = result.css;
} else {
style.type = 'text/css';
if (style.styleSheet) {
style.styleSheet.cssText = result.css;
} else {
style.innerHTML = result.css;
}
style.innerHTML = result.css;
}
}, null, style));
}
});
}
}
}
Expand Down