Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 4313 selector list not expanding #4314

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

puckowski
Copy link
Contributor

What:

PR contains a fix for issue #4313 selector list not expanding with & symbol.

Why:

In Less.js version 4.2.2, this Less:

.broken {
  &:not(&--a, &--b):hover {
    background-color: green;
  }
}

produces the incorrect CSS:

.broken:not(&--a, &--b):hover {
  background-color: green;
}

the & symbol should now be properly expanded with the fix.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

* Add support for CSS container query scroll-state.
* Fix an issue where selector with comma would not expand correctly.
* Make fix for issue less#4313 selector list not expanding correctly more
  flexible.
* Add more tests for fix for issue less#4313.
* Cleanup merge issues for fix for issue less#4313.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 1, 2025
@puckowski
Copy link
Contributor Author

Looks like CI may have an issue. Tests pass locally for me.

browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1148/chrome-linux/headless_shell
╔═════════════════════════════════════════════════════════════════════════╗
║ Looks like Playwright Test or Playwright was just installed or updated. ║
║ Please run the following command to download new browsers:              ║
║                                                                         ║
║     npx playwright install                                              ║
║                                                                         ║
║ <3 Playwright Team                                                      ║
╚═════════════════════════════════════════════════════════════════════════╝

@puckowski
Copy link
Contributor Author

I re-ran CI but ran into issues. Branch passes all tests locally for me. I wouldn't expect files changed to impact CI (two test files, one source file). Would you be able to take a look? @iChenLei

* Revise CI for missing browser issue.
* Trying to resolve CI issues with Playwright.
* Trying to resolve CI issues with Playwright.
* Trying to resolve CI issues with Playwright.
* Fix CI by pinning CI version to resolve incorrect browser binary
  downloads.
@puckowski
Copy link
Contributor Author

FYI figured out the new CI issue. Had to revise CI file to pin Playwright version to resolve browser binary mismatches. @iChenLei @matthew-dean

See files changed in this PR.

* Improve CI stability by only grabbing patch updates. This may when npm
  install runs we will not download a version of Playwright which will
  be incompatible with the browser binaries installed by CI.
* Add CI code comments about the Playwright issue that we ran into.
* Remove package.json changes per master branch updates.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 3, 2025
* Cleanup CI changes per master branch updates to CI.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 3, 2025
@puckowski
Copy link
Contributor Author

PR was updated and is now more narrow in scope. Let me know if you have an opportunity to review. @matthew-dean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants