Automatically gzip responses #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems convenient to do this in CTile rather than Nginx because (currently) it's easier for us to scale the number of CTile instances than the number of Nginx instances.
jsha
requested review from
mcpherrinm,
a team and
aarongable
and removed request for
a team
|
|
mcpherrinm
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems convenient to do this in CTile rather than Nginx because (currently) it's easier for us to scale the number of CTile instances than the number of Nginx instances.
Using NYTimes/gziphandler simplifies a little bit the handling of different cases (like whether or not the requester accepts gzip encoding).
I incorporated the gzip handler into
tileCachingHandlerrather than setting it up in main, in order to make it easier to test inside the current integration test.