Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Nix hash on PR, not on the main branch #817

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Aug 15, 2024

Fixes #816.

Also, nix build is run on the last step, to ensure the Nix package can be built successfully.

@akirak akirak mentioned this pull request Aug 15, 2024
@scohen
Copy link
Collaborator

scohen commented Aug 15, 2024

@hauleth care to comment?

@tcoopman
Copy link

tcoopman commented Sep 2, 2024

any progress on this? Wanted to update lexical but the hash was incorrect...

@hauleth
Copy link
Contributor

hauleth commented Sep 2, 2024

LGTM

@scohen scohen merged commit 371ea86 into lexical-lsp:main Sep 3, 2024
12 checks passed
@akirak akirak deleted the nix-on-pr branch September 4, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Nix hash isn't updated on CI
4 participants