Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stacklevel=2 for DeprecationWarning #10

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Set stacklevel=2 for DeprecationWarning #10

merged 1 commit into from
Nov 6, 2024

Conversation

cdce8p
Copy link

@cdce8p cdce8p commented Nov 6, 2024

Emit DeprecationWarning for caller. All other __getattr__ functions already set stacklevel=2 correctly.

warnings.warn(
f"{attr} is deprecated. Please use {new_attr} instead.",
DeprecationWarning,
stacklevel=2,
)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cdce8p
Copy link
Author

cdce8p commented Nov 6, 2024

@lextm Sorry about that, but I'm not signing a CLA for a one-line change. Feel free to use it as you see fit or close it. My intention was just to fix a small overside here.

@lextm lextm merged commit 1431e90 into lextudio:main Nov 6, 2024
1 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants