Register fixed lengths for octet strings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the purpose of generating and parsing formatted OIDs, pysnmp needs to know whether an OCTET STRING typed object has a fixed length, and if so, which length. Before the switch to Jinja2 templates, pysmi assigned such fixed lengths as "fixedLength" attributes to types. With the switch, that functionality got lost, thereby also breaking pysnmp's proper handling of formatted OIDs. This commit restores the assignment of "fixedLength" attributes. Note that as of writing, this change is necessary but not sufficient to fix the corresponding funtionality in pysnmp. The test set is extended with extra tests for this functionality, and some previously missing general tests on constraints. As part of that, a bug is fixed in an existing test wherein naming conflicts caused various bulk-generated test methods to overwrite each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores pysmi's
fixedLengthfield generation. As such, it is the fix for point (2) of my (first) comment in lextudio/pysnmp#141. That should allow fixes for pysnmp for the other two points from that comment to restore proper generation and parsing of OIDs with fixed-length string indices.This PR does not change the mibs.pysnmp.com statistics (i.e., no regressions), but there are now 9969
fixedLengthassignments across 2085 MIBs from that collection that were missing before, and those numbers are very close to the pre-Jinja2 numbers from there (9954 assignments across 2088 MIBs). Note that the collection itself has been slightly altered since then, so an exact match is not expected there. In any case, I think this is looking good.In addition, the pysmi test set is extended to 510 tests.