Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fossology workflow #736

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

tdrozdovsky
Copy link
Contributor

Description

Fix fossology error:

Traceback (most recent call last):
  File "/bin/fossologyscanner", line 273, in <module>
    sys.exit(main(args))
  File "/bin/fossologyscanner", line 231, in main
    api_config = get_api_config()
  File "/bin/fossologyscanner", line 65, in get_api_config
    api_config.project_orig = os.environ['GITHUB_REPO_OWNER']
  File "/usr/lib/python3.9/os.py", line 679, in __getitem__
    raise KeyError(key) from None
KeyError: 'GITHUB_REPO_OWNER'
Error: Process completed with exit code 1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • CI system update

Test Configuration:

  • OS type & version: Ubuntu 20.04
  • Hardware: x86-64 (e.g., x86, x86-64, arm, arm64)
  • Toolchain: Docker v20.10 & Go v1.19
  • Edge Orchestration Release: v1.2.x

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tdrozdovsky tdrozdovsky self-assigned this Dec 12, 2023
@boring-cyborg boring-cyborg bot added the CI label Dec 12, 2023
@tdrozdovsky tdrozdovsky added the bug Something isn't working label Dec 12, 2023
@tdrozdovsky
Copy link
Contributor Author

tdrozdovsky commented Dec 12, 2023

I suggest looking at the error in test-suite separately, since locally the tests work correctly, and catching this error will be quite difficult since it depends on the hardware where the github->action is running

ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
--- FAIL: TestInfo (0.04s)
    --- FAIL: TestInfo/Success (0.04s)
        cpu_test.go:389: unexpected fail
FAIL
coverage: 96.3% of statements
FAIL	github.com/lf-edge/edge-home-orchestration-go/internal/common/resourceutil/cpu	1.045s

Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tiokim
Copy link
Contributor

tiokim commented Dec 13, 2023

I suggest looking at the error in test-suite separately, since locally the tests work correctly, and catching this error will be quite difficult since it depends on the hardware where the github->action is running

ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
--- FAIL: TestInfo (0.04s)
    --- FAIL: TestInfo/Success (0.04s)
        cpu_test.go:389: unexpected fail
FAIL
coverage: 96.3% of statements
FAIL	github.com/lf-edge/edge-home-orchestration-go/internal/common/resourceutil/cpu	1.045s

What about excluding resourceutil/cpu test from the workflow?

@tdrozdovsky
Copy link
Contributor Author

I suggest looking at the error in test-suite separately, since locally the tests work correctly, and catching this error will be quite difficult since it depends on the hardware where the github->action is running

ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
--- FAIL: TestInfo (0.04s)
    --- FAIL: TestInfo/Success (0.04s)
        cpu_test.go:389: unexpected fail
FAIL
coverage: 96.3% of statements
FAIL	github.com/lf-edge/edge-home-orchestration-go/internal/common/resourceutil/cpu	1.045s

What about excluding resourceutil/cpu test from the workflow?

I'll try to fix this later. If it doesn’t work out then we’ll exclude it.

Signed-off-by: Taras Drozdovskyi <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@MoonkiHong MoonkiHong merged commit 245f054 into lf-edge:master Dec 13, 2023
14 of 15 checks passed
@tdrozdovsky tdrozdovsky deleted the fix-fossology branch May 3, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants